Code Review

Code Review Example

// Original Code
public class UserService {
    public void createUser(String name, String email) {
        if(name != null && email != null) {
            User user = new User();
            user.setName(name);
            user.setEmail(email);
            userRepository.save(user);
        }
    }
}

// Review Comments
1. Missing input validation for email format
2. No error handling for duplicate users
3. No logging for audit trail
4. Missing return value to confirm success
5. Consider using builder pattern

// Improved Code
public class UserService {
    private final UserRepository userRepository;
    private final Logger logger = LoggerFactory.getLogger(UserService.class);

    public User createUser(String name, String email) {
        validateInput(name, email);
        checkDuplicateUser(email);

        User user = User.builder()
            .name(name)
            .email(email)
            .build();

        logger.info("Creating new user: {}", email);
        return userRepository.save(user);
    }

    private void validateInput(String name, String email) {
        if (name == null || name.trim().isEmpty()) {
            throw new ValidationException("Name is required");
        }
        if (!EmailValidator.isValid(email)) {
            throw new ValidationException("Invalid email format");
        }
    }
}